Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DeletionProtectionForCRDCascadingGate #1365

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Aug 11, 2023

Ⅰ. Describe what this PR does

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 11, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@kruise-bot kruise-bot requested review from Fei-Guo and veophi August 11, 2023 03:55
@kruise-bot kruise-bot added the size/S size/S 10-29 label Aug 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #1365 (0677f12) into master (321c991) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1365   +/-   ##
=======================================
  Coverage   48.25%   48.25%           
=======================================
  Files         152      152           
  Lines       21469    21469           
=======================================
  Hits        10359    10359           
  Misses       9973     9973           
  Partials     1137     1137           
Flag Coverage Δ
unittests 48.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@zmberg zmberg force-pushed the deletionprotection-crd-gate branch from 59dcf0c to 0677f12 Compare August 16, 2023 05:12
@veophi
Copy link
Member

veophi commented Aug 16, 2023

/lgtm

@veophi
Copy link
Member

veophi commented Aug 16, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: veophi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit efadf65 into openkruise:master Aug 16, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Aug 29, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants