-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for credential provider plugin #1383
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1383 +/- ##
==========================================
+ Coverage 47.91% 49.13% +1.21%
==========================================
Files 162 183 +21
Lines 23491 18925 -4566
==========================================
- Hits 11256 9299 -1957
+ Misses 11014 8403 -2611
- Partials 1221 1223 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think it would be nice to add some more content.
|
Thanks, I'll think about these suggestions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
93caacb
to
d326724
Compare
37f72cb
to
06a14f1
Compare
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz remove binary file fake-credential-plugin from git
435985a
to
807227a
Compare
Signed-off-by: Kuromesi <blackfacepan@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Add support for credential provider plugins, by using this, Kruise can dynamically retrieve credentials for a container image registry using plugins, e.g. using STS tokens to pull image from ECR repositories. You could write your own credential provider plugins or use plugins provided by cloud providers.
This works the same way as Kubelet does, refer to Configure a kubelet image credential provider for more information.
Ⅱ. Does this pull request fix one issue?
fixes #866
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews