[1.4] Fix dockerbuild #1395
[1.4] Fix dockerbuild #1395
Conversation
Signed-off-by: Lan Liang <gcslyp@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @liangyuanpeng! It looks like this is your first PR to openkruise/kruise 🎉 |
| @@ -32,6 +32,27 @@ jobs: | |||
| with: | |||
| config: ./typos.toml | |||
|
|
|||
| docker-build: | |||
There was a problem hiding this comment.
Add CI to run docker build, does make sense? i can update it to master if necessarily.
| @@ -0,0 +1,15 @@ | |||
| name: Docker Image CI | |||
There was a problem hiding this comment.
backport PR #1393 to 1.4
| @@ -32,6 +32,27 @@ jobs: | |||
| with: | |||
| config: ./typos.toml | |||
|
|
|||
| docker-build: | |||
| runs-on: ubuntu-18.04 | |||
There was a problem hiding this comment.
Maybe we need to update the os version? it's out-of-date.
The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002
|
@zmberg |
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Build the Docker image | ||
| run: IMG=openkruise/kruise-manager:${{ github.ref_name }} & make docker-multiarch |
There was a problem hiding this comment.
make docker-multiarch will automatically push the image to the repository, this do not want, but you can play the image locally to see if it is successful, but do not push the repository
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ⅰ. Describe what this PR does
Fixes #1362
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews