[Fix] Index overshoot

[ls-2018]

When I try to manually specify a key in configmap, the controller panics

apiVersion: v1
kind: Pod
metadata:
  name: test
spec:
  containers:
    - name: main
      image: centos:7
      command:
        - "/bin/sh"
        - "-c"
        - "sleep 1d"
    - name: sidecar
      image: centos:7
      command:
        - "/bin/sh"
        - "-c"
        - "sleep 1d"
      env:
        - name: KRUISE_CONTAINER_PRIORITY
          value: "1"
        - name: KRUISE_CONTAINER_BARRIER
          valueFrom:
            configMapKeyRef:
              name: x
              key: "p"
---
apiVersion: v1
kind: ConfigMap
metadata:
  name: x
data:
  p: "1"

[ls-2018]

/assign @zmberg

[kruise-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zmberg by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zmberg]

@ls-2018 Shouldn't the user be allowed to configure KRUISE_CONTAINER_BARRIER themselves, and if they do, it should be overridden by the kruise webhook?

[ls-2018]

@zmberg I don't think we need to expose this to the user. The user just needs to operate KRUISE_CONTAINER_PRIORITY.

If the user sets KRUISE_CONTAINER_BARRIER, I personally feel that it is better to override the env, after all, this is a very special.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[kruise-bot]

@ls-2018: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.45%. Comparing base (a46e941) to head (d2be8ec).
Report is 75 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1413      +/-   ##
==========================================
+ Coverage   48.23%   48.45%   +0.21%     
==========================================
  Files         153      157       +4     
  Lines       21492    22724    +1232     
==========================================
+ Hits        10367    11010     +643     
- Misses       9985    10545     +560     
- Partials     1140     1169      +29     

Flag	Coverage Δ
unittests	48.45% <ø> (+0.21%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.