Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sidecarset upgrade exception for UpdateExpectations #1435

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Oct 16, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@kruise-bot kruise-bot requested review from FillZpp and veophi October 16, 2023 02:48
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Oct 16, 2023
@veophi
Copy link
Member

veophi commented Oct 16, 2023

/LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1435 (9be4afe) into master (459efe6) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
+ Coverage   48.21%   48.24%   +0.03%     
==========================================
  Files         153      153              
  Lines       21501    21500       -1     
==========================================
+ Hits        10366    10373       +7     
+ Misses       9993     9986       -7     
+ Partials     1142     1141       -1     
Flag Coverage Δ
unittests 48.24% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...troller/sidecarset/sidecarset_pod_event_handler.go 63.33% <ø> (-0.31%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zmberg
Copy link
Member Author

zmberg commented Oct 16, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 85cece5 into openkruise:master Oct 16, 2023
21 checks passed
@zmberg zmberg added this to the 1.6 milestone Mar 7, 2024
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants