-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix no test cases actually run in controller_revision_test file #1457
Conversation
@xiangpingjiang Please merge into a commit. |
Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>
4aa26ef
to
15620f2
Compare
@ls-2018 |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
+ Coverage 48.36% 48.39% +0.02%
==========================================
Files 154 155 +1
Lines 21679 21719 +40
==========================================
+ Hits 10486 10510 +24
- Misses 10040 10052 +12
- Partials 1153 1157 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
@xiangpingjiang can you rebase the master, the master had fixed some problem in e2e |
@furykerry There were still e2e tests failed |
@xiangpingjiang will fix soon |
@xiangpingjiang veophi just add another fix of e2e, can you rebase the master again ? |
f3487e3
to
15620f2
Compare
fbb1ded
to
15620f2
Compare
@furykerry done |
@ls-2018: No presubmit jobs available for openkruise/kruise@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xiangpingjiang Please fix the error reported in CI. |
@ls-2018 The failed CI is not because my code change. It already exists https://github.com/openkruise/kruise/actions/runs/7261379372/job/19782445025 |
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
fix no test cases actually run in controller_revision_test file
Ⅱ. Does this pull request fix one issue?
fixes #1456
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews