Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix no test cases actually run in controller_revision_test file #1457

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

xiangpingjiang
Copy link
Contributor

Ⅰ. Describe what this PR does

fix no test cases actually run in controller_revision_test file

Ⅱ. Does this pull request fix one issue?

fixes #1456

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added size/S size/S 10-29 size/XS size/XS: 0-9 and removed size/S size/S 10-29 labels Nov 23, 2023
@ls-2018
Copy link
Member

ls-2018 commented Nov 24, 2023

@xiangpingjiang Please merge into a commit.

@kruise-bot kruise-bot removed the lgtm label Nov 24, 2023
Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>
@xiangpingjiang
Copy link
Contributor Author

@xiangpingjiang Please merge into a commit.

@ls-2018
Done

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (01717ff) 48.36% compared to head (f3487e3) 48.39%.
Report is 6 commits behind head on master.

❗ Current head f3487e3 differs from pull request most recent head 15620f2. Consider uploading reports for the commit 15620f2 to get more accurate results

Files Patch % Lines
...rcedistribution/resourcedistribution_controller.go 0.00% 10 Missing ⚠️
pkg/daemon/criruntime/imageruntime/cri.go 0.00% 2 Missing ⚠️
pkg/daemon/criruntime/imageruntime/containerd.go 0.00% 1 Missing ⚠️
pkg/daemon/criruntime/imageruntime/docker.go 0.00% 1 Missing ⚠️
pkg/daemon/criruntime/imageruntime/pouch.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
+ Coverage   48.36%   48.39%   +0.02%     
==========================================
  Files         154      155       +1     
  Lines       21679    21719      +40     
==========================================
+ Hits        10486    10510      +24     
- Misses      10040    10052      +12     
- Partials     1153     1157       +4     
Flag Coverage Δ
unittests 48.39% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ls-2018
Copy link
Member

ls-2018 commented Nov 28, 2023

/lgtm

@furykerry
Copy link
Member

@xiangpingjiang can you rebase the master, the master had fixed some problem in e2e

@kruise-bot kruise-bot removed the lgtm label Dec 4, 2023
@xiangpingjiang
Copy link
Contributor Author

@xiangpingjiang can you rebase the master, the master had fixed some problem in e2e

@furykerry There were still e2e tests failed

@veophi
Copy link
Member

veophi commented Dec 6, 2023

@xiangpingjiang can you rebase the master, the master had fixed some problem in e2e

@furykerry There were still e2e tests failed

@xiangpingjiang will fix soon

@furykerry
Copy link
Member

@xiangpingjiang veophi just add another fix of e2e, can you rebase the master again ?

@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/XS size/XS: 0-9 labels Dec 13, 2023
@kruise-bot kruise-bot added size/XS size/XS: 0-9 size/L size/L: 100-499 and removed size/M size/M: 30-99 size/XS size/XS: 0-9 labels Dec 13, 2023
@kruise-bot kruise-bot removed the size/L size/L: 100-499 label Dec 13, 2023
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Dec 13, 2023
@xiangpingjiang
Copy link
Contributor Author

@xiangpingjiang veophi just add another fix of e2e, can you rebase the master again ?

@furykerry done

@kruise-bot
Copy link

@ls-2018: No presubmit jobs available for openkruise/kruise@master

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ls-2018
Copy link
Member

ls-2018 commented Dec 19, 2023

@xiangpingjiang Please fix the error reported in CI.

@xiangpingjiang
Copy link
Contributor Author

@xiangpingjiang Please fix the error reported in CI.

@ls-2018 The failed CI is not because my code change. It already exists https://github.com/openkruise/kruise/actions/runs/7261379372/job/19782445025

@ls-2018
Copy link
Member

ls-2018 commented Dec 20, 2023

/lgtm

@furykerry
Copy link
Member

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 891ce97 into openkruise:master Dec 20, 2023
24 of 25 checks passed
@zmberg zmberg added this to the 1.6 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] no test cases actually run in controller_revision_test file
7 participants