Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codeql.yml #1461

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

furykerry
Copy link
Member

Ⅰ. Describe what this PR does

add static code analysis

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/M size/M: 30-99 label Nov 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8994e7) 48.34% compared to head (0dc926a) 48.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1461   +/-   ##
=======================================
  Coverage   48.34%   48.35%           
=======================================
  Files         154      154           
  Lines       21663    21663           
=======================================
+ Hits        10473    10475    +2     
+ Misses      10038    10037    -1     
+ Partials     1152     1151    -1     
Flag Coverage Δ
unittests 48.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@furykerry furykerry force-pushed the create-codeql-for-sast branch 4 times, most recently from 58cbfa5 to 45bb5b4 Compare November 30, 2023 08:25
@kruise-bot kruise-bot added size/L size/L: 100-499 and removed size/M size/M: 30-99 labels Nov 30, 2023
Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com>
@furykerry
Copy link
Member Author

/test

@kruise-bot
Copy link

@furykerry: No presubmit jobs available for openkruise/kruise@master

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zmberg
Copy link
Member

zmberg commented Dec 1, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Dec 1, 2023

/approve

@furykerry
Copy link
Member Author

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry, zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 6a62320 into openkruise:master Dec 1, 2023
25 checks passed
xiangpingjiang pushed a commit to xiangpingjiang/kruise that referenced this pull request Dec 13, 2023
Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com>
Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>
@zmberg zmberg added this to the 1.6 milestone Mar 7, 2024
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants