-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: find workload spec.replicas #1462
Conversation
Welcome @0xgj! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1462 +/- ##
==========================================
- Coverage 48.30% 47.34% -0.97%
==========================================
Files 154 156 +2
Lines 21667 22150 +483
==========================================
+ Hits 10467 10487 +20
- Misses 10048 10514 +466
+ Partials 1152 1149 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/test |
/assign @furykerry |
@0xgj please use |
/lgtm |
Signed-off-by: kim <4017010+0xgj@users.noreply.github.com>
/lgtm |
@furykerry can you help merge this commit? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
fix get
spec.replicas
from unstructured object.Ⅱ. Does this pull request fix one issue?
unstructured.NestedInt64(obj, "spec.replicas")
can not get replicas from like:Ⅲ. Describe how to verify it
test it use TApp https://github.com/tkestack/tapp.
kruise.io/auto-generate-persistent-pod-state: "true"
,kruise.io/preferred-persistent-topology: kubernetes.io/hostname
example-tapp-0
and recreate example-tapp-0, get pod yam, nodeAffinity injectedl:Ⅳ. Special notes for reviews