[Fix] ResourceDistribution should watch unstructured object #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1464 +/- ##
==========================================
- Coverage 48.36% 48.36% -0.01%
==========================================
Files 154 154
Lines 21679 21659 -20
==========================================
- Hits 10486 10475 -11
+ Misses 10040 10033 -7
+ Partials 1153 1151 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
veophi
changed the title
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xiangpingjiang
pushed a commit
to xiangpingjiang/kruise
that referenced
this pull request
Dec 13, 2023
…se#1464) * fix resourcedistribution event watch Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> * fix image list pull job e2e Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> --------- Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
xiangpingjiang
pushed a commit
to xiangpingjiang/kruise
that referenced
this pull request
Dec 13, 2023
…se#1464) * fix resourcedistribution event watch Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> * fix image list pull job e2e Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> --------- Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
…se#1464) * fix resourcedistribution event watch * fix image list pull job e2e --------- Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews