-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restrict the access permissions of kruise-daemon to secrets #1482
Conversation
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1482 +/- ##
==========================================
+ Coverage 47.66% 47.99% +0.33%
==========================================
Files 157 157
Lines 22427 22432 +5
==========================================
+ Hits 10689 10766 +77
+ Misses 10570 10479 -91
- Partials 1168 1187 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
f710c02
to
6071d80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* restrict the access permissions of kruise-daemon to secrets Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> * util meta ut Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> --------- Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
* restrict the access permissions of kruise-daemon to secrets Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> * util meta ut Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> --------- Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
* restrict the access permissions of kruise-daemon to secrets Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> * util meta ut Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> --------- Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
…se#1482) * restrict the access permissions of kruise-daemon to secrets * util meta ut --------- Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews