Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the dependency of kruise project will be updated to kubernetes 1.26.10 version #1511

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

BH4AWS
Copy link
Collaborator

@BH4AWS BH4AWS commented Feb 26, 2024

Ⅰ. Describe what this PR does

The kubernetes dependency of this project will be updated to 1.26.10 version(controller runtime to v0.14.0).

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@BH4AWS BH4AWS force-pushed the update_to_k8s126 branch 2 times, most recently from 5de7b25 to ba91001 Compare February 27, 2024 10:17
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 47.93%. Comparing base (861818e) to head (ffbf0b0).

Files Patch % Lines
pkg/daemon/criruntime/imageruntime/helpers.go 0.00% 4 Missing ⚠️
pkg/daemon/criruntime/imageruntime/cri.go 0.00% 3 Missing ⚠️
...troller/nodepodprobe/nodepodprobe_event_handler.go 0.00% 2 Missing ⚠️
pkg/daemon/podprobe/pod_probe_controller.go 0.00% 2 Missing ⚠️
pkg/control/pubcontrol/pub_control_utils.go 0.00% 1 Missing ⚠️
pkg/control/sidecarcontrol/history_control.go 0.00% 1 Missing ⚠️
pkg/controller/statefulset/stateful_set_control.go 0.00% 1 Missing ⚠️
pkg/daemon/podprobe/prober.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
+ Coverage   47.89%   47.93%   +0.04%     
==========================================
  Files         161      161              
  Lines       23428    23425       -3     
==========================================
+ Hits        11220    11228       +8     
+ Misses      10995    10985      -10     
+ Partials     1213     1212       -1     
Flag Coverage Δ
unittests 47.93% <40.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: jicheng.sk <jicheng.sk@alibaba-inc.com>
@furykerry
Copy link
Member

/lgtm

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit c33088b into openkruise:master Mar 13, 2024
33 of 34 checks passed
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Co-authored-by: jicheng.sk <jicheng.sk@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants