Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cloneset revision update #1549

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

qswksp
Copy link
Contributor

@qswksp qswksp commented Mar 28, 2024

Ⅰ. Describe what this PR does

#1545

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link

Welcome @qswksp! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Mar 28, 2024
@qswksp qswksp closed this Mar 28, 2024
@zmberg zmberg reopened this Mar 29, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.97%. Comparing base (912de49) to head (13bf940).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1549      +/-   ##
==========================================
+ Coverage   47.90%   47.97%   +0.06%     
==========================================
  Files         162      162              
  Lines       23491    23491              
==========================================
+ Hits        11254    11270      +16     
+ Misses      11017    11005      -12     
+ Partials     1220     1216       -4     
Flag Coverage Δ
unittests 47.97% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member

zmberg commented Apr 1, 2024

@qswksp Can you squash the commit?

Signed-off-by: suhe <suhe@njust.edu.cn>
@kruise-bot kruise-bot removed the lgtm label Apr 1, 2024
@qswksp qswksp closed this Apr 1, 2024
@qswksp qswksp reopened this Apr 1, 2024
@qswksp qswksp closed this Apr 1, 2024
@qswksp qswksp reopened this Apr 1, 2024
@qswksp qswksp closed this Apr 1, 2024
@qswksp qswksp reopened this Apr 1, 2024
@qswksp qswksp closed this Apr 1, 2024
@qswksp qswksp reopened this Apr 1, 2024
@zmberg
Copy link
Member

zmberg commented Apr 1, 2024

/lgtm

@zmberg
Copy link
Member

zmberg commented Apr 1, 2024

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 1f7b691 into openkruise:master Apr 1, 2024
138 of 142 checks passed
zmberg pushed a commit that referenced this pull request Apr 3, 2024
Signed-off-by: suhe <suhe@njust.edu.cn>
zmberg pushed a commit that referenced this pull request Apr 3, 2024
Signed-off-by: suhe <suhe@njust.edu.cn>
zmberg pushed a commit that referenced this pull request Apr 3, 2024
Signed-off-by: suhe <suhe@njust.edu.cn>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants