Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove vendor. #1554

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

liangyuanpeng
Copy link
Contributor

Ⅰ. Describe what this PR does

Fixes #1533
/assign @zmberg

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.03%. Comparing base (0d0031a) to head (511e1d1).
Report is 1 commits behind head on master.

❗ Current head 511e1d1 differs from pull request most recent head da11ebe. Consider uploading reports for the commit da11ebe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1554      +/-   ##
==========================================
+ Coverage   47.91%   48.03%   +0.12%     
==========================================
  Files         162      162              
  Lines       23491    23491              
==========================================
+ Hits        11256    11285      +29     
+ Misses      11014    10995      -19     
+ Partials     1221     1211      -10     
Flag Coverage Δ
unittests 48.03% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmberg
Copy link
Member

zmberg commented Apr 1, 2024

@liangyuanpeng liangyuanpeng reopened this Apr 5, 2024
@liangyuanpeng liangyuanpeng changed the title chorme: remove vendor. chore: remove vendor. Apr 5, 2024
@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Apr 5, 2024

Upgrades controller-gen from 0.11.0 to 0.14.0 to fix kubernetes-sigs/controller-tools#880, and this is resolved by #1562, so let's waiting for #1562

@liangyuanpeng
Copy link
Contributor Author

/hold

@liangyuanpeng
Copy link
Contributor Author

/retest

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@liangyuanpeng
Copy link
Contributor Author

@zmberg PTAL Thanks

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

@liangyuanpeng is the patch ready for merge? the patch is still labeled with "do-not-merge" label

@liangyuanpeng
Copy link
Contributor Author

is the patch ready for merge?

Absolutely,Thanks for remind.

/hold cancel

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 8f98ce4 into openkruise:master Apr 15, 2024
32 checks passed
@liangyuanpeng liangyuanpeng deleted the rm_vendor branch April 15, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Remove go mod vendor
4 participants