Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky ut #1556

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Fix flaky ut #1556

merged 6 commits into from
Apr 1, 2024

Conversation

furykerry
Copy link
Member

Ⅰ. Describe what this PR does

fix #1555

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and zmberg April 1, 2024 05:40
@kruise-bot kruise-bot added the size/S size/S 10-29 label Apr 1, 2024
Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com>
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.93%. Comparing base (014b824) to head (6467a5f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1556      +/-   ##
==========================================
+ Coverage   47.90%   47.93%   +0.02%     
==========================================
  Files         162      162              
  Lines       23491    23491              
==========================================
+ Hits        11254    11260       +6     
+ Misses      11017    11013       -4     
+ Partials     1220     1218       -2     
Flag Coverage Δ
unittests 47.93% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmberg
Copy link
Member

zmberg commented Apr 1, 2024

/lgtm

@zmberg
Copy link
Member

zmberg commented Apr 1, 2024

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 1f00e6b into openkruise:master Apr 1, 2024
34 checks passed
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
* update meeting time and links for community call


* update meeting time and links for community call


* fix flaky unit test


---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] flaky unit test TestRevisionManage
3 participants