-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: WorkloadSpread feature judgment #1566
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1566 +/- ##
==========================================
+ Coverage 47.97% 48.55% +0.57%
==========================================
Files 162 163 +1
Lines 23491 18900 -4591
==========================================
- Hits 11270 9177 -2093
+ Misses 11005 8504 -2501
- Partials 1216 1219 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ls-2018 Creating workloadSpread fails when featureGate is false, refer code: https://github.com/openkruise/kruise/blob/master/pkg/webhook/workloadspread/validating/workloadspread_create_update_handler.go#L46 |
@ls-2018 It shouldn't be allowed to be created, and when it is created it just gives an error telling him that he should open the featrueGate to do so. |
Signed-off-by: acejilam <acejilam@gmail.com>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: acejilam <acejilam@gmail.com>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews