Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WorkloadSpread feature judgment #1566

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

ls-2018
Copy link
Member

@ls-2018 ls-2018 commented Apr 6, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and veophi April 6, 2024 09:45
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Apr 6, 2024
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 48.55%. Comparing base (1f00e6b) to head (d832ed6).
Report is 21 commits behind head on master.

Files Patch % Lines
...validating/workloadspread_create_update_handler.go 0.00% 2 Missing ⚠️
...roller/workloadspread/workloadspread_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1566      +/-   ##
==========================================
+ Coverage   47.97%   48.55%   +0.57%     
==========================================
  Files         162      163       +1     
  Lines       23491    18900    -4591     
==========================================
- Hits        11270     9177    -2093     
+ Misses      11005     8504    -2501     
- Partials     1216     1219       +3     
Flag Coverage Δ
unittests 48.55% <0.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmberg
Copy link
Member

zmberg commented Apr 7, 2024

@ls-2018
Copy link
Member Author

ls-2018 commented Apr 7, 2024

image

plz ignore the file directory

@zmberg
Copy link
Member

zmberg commented Apr 15, 2024

@ls-2018 It shouldn't be allowed to be created, and when it is created it just gives an error telling him that he should open the featrueGate to do so.

Signed-off-by: acejilam <acejilam@gmail.com>
@kruise-bot kruise-bot added size/S size/S 10-29 and removed size/XS size/XS: 0-9 labels Apr 17, 2024
@zmberg
Copy link
Member

zmberg commented Apr 23, 2024

/lgtm

@zmberg
Copy link
Member

zmberg commented Apr 23, 2024

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 36cc7d8 into openkruise:master Apr 23, 2024
33 of 34 checks passed
ABNER-1 pushed a commit to ABNER-1/kruise that referenced this pull request Apr 29, 2024
Signed-off-by: acejilam <acejilam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants