Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump deps k8s to 1.28 #1598

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Apr 26, 2024

Ⅰ. Describe what this PR does

bump deps k8s to 1.28

fix #1541

todo #1597

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

important break changes in controller-runtime:

image
image
image

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 19.58763% with 234 lines in your changes are missing coverage. Please review.

Project coverage is 48.95%. Comparing base (0d0031a) to head (c1c1a4b).
Report is 27 commits behind head on master.

Files Patch % Lines
...rcedistribution/resourcedistribution_controller.go 0.00% 20 Missing ⚠️
...tentpodstate/persistent_pod_state_event_handler.go 0.00% 16 Missing ⚠️
pkg/controller/daemonset/daemonset_controller.go 13.33% 10 Missing and 3 partials ⚠️
...troller/broadcastjob/broadcastjob_event_handler.go 0.00% 12 Missing ⚠️
...troller/imagepulljob/imagepulljob_event_handler.go 0.00% 12 Missing ⚠️
...troller/nodepodprobe/nodepodprobe_event_handler.go 8.33% 11 Missing ⚠️
...imagelistpulljob/imagelistpulljob_event_handler.go 0.00% 8 Missing ⚠️
...ler/podprobemarker/podprobemarker_event_handler.go 12.50% 7 Missing ⚠️
...roller/workloadspread/workloadspread_controller.go 0.00% 7 Missing ⚠️
...availablebudget/podunavailablebudget_controller.go 0.00% 6 Missing ⚠️
... and 37 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
+ Coverage   47.91%   48.95%   +1.04%     
==========================================
  Files         162      180      +18     
  Lines       23491    18778    -4713     
==========================================
- Hits        11256     9193    -2063     
+ Misses      11014     8374    -2640     
+ Partials     1221     1211      -10     
Flag Coverage Δ
unittests 48.95% <19.58%> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABNER-1
Copy link
Member Author

ABNER-1 commented Apr 29, 2024

squash commits

Signed-off-by: Abner-1 <Abner199709@gmail.com>
@ABNER-1
Copy link
Member Author

ABNER-1 commented May 7, 2024

rebase and retest

@zmberg
Copy link
Member

zmberg commented May 8, 2024

/lgtm
/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 9959b03 into openkruise:master May 8, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Bump K8s dependency to 1.28
3 participants