Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make docker-multiarch failed with vendor errors #1601

Conversation

MichaelRren
Copy link
Contributor

Ⅰ. Describe what this PR does

fix vendor error while running command make docker-multiarch

Ⅱ. Does this pull request fix one issue?

fixes #1599

Ⅲ. Describe how to verify it

run command with make docker-multiarch and it works

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from Fei-Guo and furykerry April 29, 2024 07:03
@kruise-bot
Copy link

Welcome @MichaelRren! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Apr 29, 2024
@ABNER-1
Copy link
Member

ABNER-1 commented Apr 29, 2024

You need to Signed-off your commit https://github.com/openkruise/kruise/pull/1601/checks?check_run_id=24362339031

@MichaelRren MichaelRren reopened this Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.94%. Comparing base (0d0031a) to head (495005f).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
+ Coverage   47.91%   48.94%   +1.02%     
==========================================
  Files         162      180      +18     
  Lines       23491    18778    -4713     
==========================================
- Hits        11256     9191    -2065     
+ Misses      11014     8375    -2639     
+ Partials     1221     1212       -9     
Flag Coverage Δ
unittests 48.94% <ø> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelRren MichaelRren force-pushed the multiarch_failed_with_vendor_errors branch from ed3917d to ea20f67 Compare April 29, 2024 07:14
@ABNER-1
Copy link
Member

ABNER-1 commented May 8, 2024

Hi, @MichaelRren.

Thank you for your contribution. A pull request to upgrade Kubernetes dependencies to version 1.28 has been approved and merged into the master branch. We now need to make some adjustments to the docker-multiarch configuration to ensure compatibility.

image

Signed-off-by: haoshi.ren <haoshi.ren@smartx.com>
@MichaelRren MichaelRren force-pushed the multiarch_failed_with_vendor_errors branch from ea20f67 to 495005f Compare May 8, 2024 02:22
@ABNER-1
Copy link
Member

ABNER-1 commented May 8, 2024

/lgtm

@kruise-bot
Copy link

@ABNER-1: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@furykerry
Copy link
Member

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 4c3b681 into openkruise:master May 8, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] make docker-multiarch failed with vendor errors
4 participants