-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make docker-multiarch failed with vendor errors #1601
fix: make docker-multiarch failed with vendor errors #1601
Conversation
Welcome @MichaelRren! It looks like this is your first PR to openkruise/kruise 🎉 |
You need to Signed-off your commit https://github.com/openkruise/kruise/pull/1601/checks?check_run_id=24362339031 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1601 +/- ##
==========================================
+ Coverage 47.91% 48.94% +1.02%
==========================================
Files 162 180 +18
Lines 23491 18778 -4713
==========================================
- Hits 11256 9191 -2065
+ Misses 11014 8375 -2639
+ Partials 1221 1212 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ed3917d
to
ea20f67
Compare
Hi, @MichaelRren. Thank you for your contribution. A pull request to upgrade Kubernetes dependencies to version 1.28 has been approved and merged into the master branch. We now need to make some adjustments to the docker-multiarch configuration to ensure compatibility. |
Signed-off-by: haoshi.ren <haoshi.ren@smartx.com>
ea20f67
to
495005f
Compare
/lgtm |
@ABNER-1: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
fix vendor error while running command make docker-multiarch
Ⅱ. Does this pull request fix one issue?
fixes #1599
Ⅲ. Describe how to verify it
run command with make docker-multiarch and it works
Ⅳ. Special notes for reviews