-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ephemeraljob validating webhook #1615
Conversation
9a68014
to
06ed285
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1615 +/- ##
==========================================
+ Coverage 47.91% 49.16% +1.24%
==========================================
Files 162 183 +21
Lines 23491 18921 -4570
==========================================
- Hits 11256 9302 -1954
+ Misses 11014 8398 -2616
Partials 1221 1221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pkg/webhook/ephemeraljob/validating/ephemeraljob_create_update_handler.go
Outdated
Show resolved
Hide resolved
06ed285
to
3037dd3
Compare
3037dd3
to
e0a56bf
Compare
e0a56bf
to
7838bde
Compare
7838bde
to
fc48f67
Compare
fc48f67
to
c77a185
Compare
3d67224
to
cca847d
Compare
Signed-off-by: Abner-1 <Abner199709@gmail.com>
cca847d
to
7b495c6
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
fix #1614
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Invalid ejob must be rejected by webhook.
![image](https://private-user-images.githubusercontent.com/24547351/329752415-825b3174-9b95-4c7f-a400-6030e097d4aa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ2MTQ5MjgsIm5iZiI6MTcyNDYxNDYyOCwicGF0aCI6Ii8yNDU0NzM1MS8zMjk3NTI0MTUtODI1YjMxNzQtOWI5NS00YzdmLWE0MDAtNjAzMGUwOTdkNGFhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI1VDE5MzcwOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU2OTVjYzVjMDQ1MGNmMDE2NjdlZDBjZTViNWIyNGIwODZhNjk3MTNhZGE0ODM4NzI1NTc1N2ZlNTdiYzlmZTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.7JGJlkvWCobalyMaA0HnUNeCqTTgjGXyPBAwnpGgFQk)
For example:
Ⅳ. Special notes for reviews