Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] update CI test image centos:6.7 to centos:7 to support run CI on arm #1623

Merged
merged 1 commit into from
May 15, 2024

Conversation

Colvin-Y
Copy link
Contributor

Ⅰ. Describe what this PR does

Update sts image in CI from centos:6.7 to centos:7 because version 7 is a multi-arch image but 6.7 not.

Ⅱ. Does this pull request fix one issue?

Fix issue #1616

Ⅲ. Describe how to verify it

All github CI should pass, and also this case can run on arm machine.

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and veophi May 15, 2024 09:45
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label May 15, 2024
update CI test image centos:6.7 to centos:7 to support run CI on arm
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.01%. Comparing base (0d0031a) to head (29c8290).
Report is 34 commits behind head on master.

❗ Current head 29c8290 differs from pull request most recent head 8a8384c. Consider uploading reports for the commit 8a8384c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
+ Coverage   47.91%   49.01%   +1.09%     
==========================================
  Files         162      180      +18     
  Lines       23491    18803    -4688     
==========================================
- Hits        11256     9216    -2040     
+ Misses      11014     8375    -2639     
+ Partials     1221     1212       -9     
Flag Coverage Δ
unittests 49.01% <ø> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@furykerry
Copy link
Member

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit a836e90 into openkruise:master May 15, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants