Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix miss makezero bug #1628

Merged
merged 1 commit into from
May 27, 2024

Conversation

alingse
Copy link
Contributor

@alingse alingse commented May 26, 2024

Ⅰ. Describe what this PR does

I was running github actions to run linter makezero for top github golang repos.

see issues alingse/go-linter-runner#1

and the github actions output https://github.com/alingse/go-linter-runner/actions/runs/9242658768/job/25425757534

====================================================================================================
append to slice `names` with non-zero initialized length at https://github.com/openkruise/kruise/blob/master/pkg/util/imagejob/imagejob_reader.go#L60:11
====================================================================================================

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

the names no need empty string value

Ⅳ. Special notes for reviews

Signed-off-by: alingse <alingse@foxmail.com>
@kruise-bot kruise-bot requested review from Fei-Guo and veophi May 26, 2024 15:39
@kruise-bot
Copy link

Welcome @alingse! It looks like this is your first PR to openkruise/kruise 🎉

Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.04%. Comparing base (0d0031a) to head (91e3ef5).
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
+ Coverage   47.91%   49.04%   +1.12%     
==========================================
  Files         162      180      +18     
  Lines       23491    18803    -4688     
==========================================
- Hits        11256     9221    -2035     
+ Misses      11014     8371    -2643     
+ Partials     1221     1211      -10     
Flag Coverage Δ
unittests 49.04% <100.00%> (+1.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 89d9558 into openkruise:master May 27, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants