Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pod index label for Advanced StatefulSet #1667

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

cr7258
Copy link
Contributor

@cr7258 cr7258 commented Jul 21, 2024

Ⅰ. Describe what this PR does

Add Pod Index Label for Advanced StatefulSet.

Ⅱ. Does this pull request fix one issue?

fixes #1660

Ⅲ. Describe how to verify it

Deploy an Advanced StatefulSet resource.

apiVersion: apps.kruise.io/v1beta1
kind: StatefulSet
metadata:
  name: sample
spec:
  replicas: 3
  serviceName: fake-service
  selector:
    matchLabels:
      app: sample
  template:
    metadata:
      labels:
        app: sample
    spec:
      containers:
      - name: main
        image: nginx:1.21

The Pod is added an apps.kubernetes.io/pod-index label.

labels:
  apps.kubernetes.io/pod-index: "1"

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and veophi July 21, 2024 04:07
@kruise-bot
Copy link

Welcome @cr7258! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/S size/S 10-29 label Jul 21, 2024
@cr7258 cr7258 force-pushed the pod-index-label branch from 3c5a8a1 to 1aa682f Compare July 21, 2024 04:07
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.84%. Comparing base (0d0031a) to head (abdcf23).
Report is 55 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
+ Coverage   47.91%   48.84%   +0.92%     
==========================================
  Files         162      188      +26     
  Lines       23491    19273    -4218     
==========================================
- Hits        11256     9414    -1842     
+ Misses      11014     8630    -2384     
- Partials     1221     1229       +8     
Flag Coverage Δ
unittests 48.84% <100.00%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Jul 21, 2024
@cr7258 cr7258 force-pushed the pod-index-label branch from bea2ff0 to 330a7dd Compare July 21, 2024 05:06
@furykerry
Copy link
Member

@cr7258 plz rebase the master and resolve the conflicts

@kruise-bot kruise-bot added needs-rebase size/S size/S 10-29 and removed needs-rebase size/M size/M: 30-99 labels Jul 22, 2024
@cr7258
Copy link
Contributor Author

cr7258 commented Jul 22, 2024

@furykerry resolved the conflict, please review it again, thanks.

@furykerry
Copy link
Member

plz resolve the conflicts by rebasing the master, and plz squash the commits into one

@cr7258 cr7258 force-pushed the pod-index-label branch from c9158e6 to 6c2aa29 Compare July 23, 2024 03:14
@kruise-bot kruise-bot added needs-rebase size/XL size/XL: 500-999 and removed size/S size/S 10-29 labels Jul 23, 2024
Signed-off-by: Se7en <chengzw258@163.com>
@cr7258 cr7258 force-pushed the pod-index-label branch from 6c2aa29 to abdcf23 Compare July 23, 2024 03:17
@kruise-bot kruise-bot added size/S size/S 10-29 and removed needs-rebase size/XL size/XL: 500-999 labels Jul 23, 2024
@furykerry
Copy link
Member

/lgtm

@ABNER-1
Copy link
Member

ABNER-1 commented Jul 23, 2024

/lgtm

@kruise-bot
Copy link

@ABNER-1: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 71c6e7a into openkruise:master Jul 23, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Add StatefulSet pod index as pod label
4 participants