Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil panic in cloneset validating webhook #1678

Conversation

Spground
Copy link
Contributor

Ⅰ. Describe what this PR does

Fix potential nil panic in CloneSet validating webhook when Pod's controller owner ref is nil.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: Spground <pingshan.wj@alibaba-inc.com>
@kruise-bot kruise-bot requested review from furykerry and veophi July 31, 2024 06:16
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.81%. Comparing base (0d0031a) to head (be5142f).
Report is 58 commits behind head on master.

Files Patch % Lines
pkg/webhook/cloneset/validating/validation.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1678      +/-   ##
==========================================
+ Coverage   47.91%   48.81%   +0.90%     
==========================================
  Files         162      188      +26     
  Lines       23491    19278    -4213     
==========================================
- Hits        11256     9411    -1845     
+ Misses      11014     8636    -2378     
- Partials     1221     1231      +10     
Flag Coverage Δ
unittests 48.81% <0.00%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABNER-1
Copy link
Member

ABNER-1 commented Jul 31, 2024

/lgtm

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 61ee5bc into openkruise:master Jul 31, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants