Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kind install bug #1688

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Aug 2, 2024

Ⅰ. Describe what this PR does

auto install kind when make create-cluster

Ⅱ. Does this pull request fix one issue?

fixes #1686

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Aug 2, 2024
Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.85%. Comparing base (0d0031a) to head (c8d3030).
Report is 82 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1688      +/-   ##
==========================================
+ Coverage   47.91%   48.85%   +0.93%     
==========================================
  Files         162      188      +26     
  Lines       23491    19289    -4202     
==========================================
- Hits        11256     9423    -1833     
+ Misses      11014     8637    -2377     
- Partials     1221     1229       +8     
Flag Coverage Δ
unittests 48.85% <ø> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@furykerry
Copy link
Member

/lgtm

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 179d759 into openkruise:master Sep 5, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] local kind test tools are invalid
3 participants