Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BroadcastJob Controller list pods add the disableDeepCopy optio… #1695

Closed
wants to merge 1 commit into from

Conversation

Prepmachine4
Copy link
Contributor

…ns (#1593)

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

…ns (openkruise#1593)

Signed-off-by: Prepmachine4 <prepmachine4@gmail.com>
@kruise-bot kruise-bot requested review from Fei-Guo and veophi August 6, 2024 12:24
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @Prepmachine4! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Aug 6, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.88%. Comparing base (0d0031a) to head (a59c3e1).
Report is 78 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
+ Coverage   47.91%   48.88%   +0.96%     
==========================================
  Files         162      188      +26     
  Lines       23491    19289    -4202     
==========================================
- Hits        11256     9429    -1827     
+ Misses      11014     8631    -2383     
- Partials     1221     1229       +8     
Flag Coverage Δ
unittests 48.88% <100.00%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants