Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BroadcastJob Controller add disableDeepCopy options #1696

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Prepmachine4
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #1593

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

It seems that my changes have met the requirements. Maybe I have misunderstood something? Please give me some guidance.

…ns (openkruise#1593)

Signed-off-by: Prepmachine4 <prepmachine4@gmail.com>
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Aug 6, 2024
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member

zmberg commented Aug 28, 2024

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit d25f72f into openkruise:master Aug 28, 2024
71 of 73 checks passed
zerunhu pushed a commit to zerunhu/kruise that referenced this pull request Sep 3, 2024
zerunhu pushed a commit to zerunhu/kruise that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Optimizing BroadcastJob Performance
4 participants