Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the token-permission and pinned dependencies issue #1707

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

harshitasao
Copy link
Contributor

Ⅰ. Describe what this PR does

Fixed the token-permission and pinned dependencies issue reported by scorecard.

Ⅱ. Does this pull request fix one issue?

Part of #1706

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: harshitasao <harshitasao@gmail.com>
@kruise-bot kruise-bot added the size/L size/L: 100-499 label Aug 18, 2024
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.84%. Comparing base (0d0031a) to head (fc4befe).
Report is 70 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
+ Coverage   47.91%   48.84%   +0.93%     
==========================================
  Files         162      188      +26     
  Lines       23491    19289    -4202     
==========================================
- Hits        11256     9422    -1834     
+ Misses      11014     8636    -2378     
- Partials     1221     1231      +10     
Flag Coverage Δ
unittests 48.84% <ø> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@furykerry
Copy link
Member

@harshitasao thanks for your effort to find detailed hash for each dependency

/lgtm
/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 11fdf8f into openkruise:master Aug 19, 2024
40 checks passed
zerunhu pushed a commit to zerunhu/kruise that referenced this pull request Sep 3, 2024
zerunhu pushed a commit to zerunhu/kruise that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants