remove normal initcontainer in sidecarset's sidecar list #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1719 +/- ##
==========================================
+ Coverage 47.91% 49.17% +1.26%
==========================================
Files 162 191 +29
Lines 23491 19561 -3930
==========================================
- Hits 11256 9620 -1636
+ Misses 11014 8691 -2323
- Partials 1221 1250 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
furykerry
reviewed
Aug 30, 2024
pkg/control/sidecarcontrol/util.go
Outdated
| @@ -575,3 +568,17 @@ func IsSidecarContainer(container corev1.Container) bool { | |||
| } | |||
| return false | |||
| } | |||
|
|
|||
| // ListSidecarNameInSidecarSet list always init containers and sidecar containers | |||
| func ListSidecarNameInSidecarSet(sidecarSet *appsv1alpha1.SidecarSet) sets.String { | |||
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
zmberg
force-pushed
the
fix-sidecarset-list
branch
from
919e550 to
4405f71
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zerunhu
pushed a commit
to zerunhu/kruise
that referenced
this pull request
Sep 3, 2024
…1719) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
zerunhu
pushed a commit
to zerunhu/kruise
that referenced
this pull request
Sep 3, 2024
…1719) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
zmberg
added a commit
that referenced
this pull request
Sep 5, 2024
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews