Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proposal about better ImagePullJob usage #1848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Dec 6, 2024

Ⅰ. Describe what this PR does

Optimization solutions for imagePullJob in special scenarios:

  1. Users may require that pre-download image only when P2P is active.
  2. In P2P scenarios, it is not preferred to pre-download too many images globally at the same time.
  3. Restrict the number of images being pre-downloaded simultaneously on a single node

Ⅱ. Does this pull request fix one issue?

about #1682 #1679 #1681

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.97%. Comparing base (0d0031a) to head (fbaed6b).
Report is 126 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1848      +/-   ##
==========================================
+ Coverage   47.91%   49.97%   +2.05%     
==========================================
  Files         162      192      +30     
  Lines       23491    24668    +1177     
==========================================
+ Hits        11256    12327    +1071     
- Misses      11014    11067      +53     
- Partials     1221     1274      +53     
Flag Coverage Δ
unittests 49.97% <ø> (+2.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant