-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: SidecarSet injection supports Partial strategy #1856
base: master
Are you sure you want to change the base?
Feature: SidecarSet injection supports Partial strategy #1856
Conversation
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
@furykerry please help me to name the TODOSidecarSetInjectRevisionPolicy |
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
+ Coverage 47.91% 50.05% +2.13%
==========================================
Files 162 192 +30
Lines 23491 24717 +1226
==========================================
+ Hits 11256 12372 +1116
- Misses 11014 11071 +57
- Partials 1221 1274 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
/lgtm |
Ⅰ. Describe what this PR does
Now, SidecarSet supports two policies in
injectionStrategy
:Always
, which is the default and current policy. Under this policy, all newly created Pods will be injected with the specified revision ininjectionStrategy
.Partial
, under which only when the Pod is not selected by the Selector explicitly configured inUpdateStrategy
will it be definitely injected with the specified revision. In all other conditions, newly created Pods have a probability of being injected with the latest Sidecar, where the probability is1 - UpdateStrategy.Partition
. IfPartition
is not a percentage or is not configured, its value is considered to be 0%.Ⅱ. Does this pull request fix one issue?
fixes #1833
Ⅲ. Describe how to verify it
see the unit tests added
Ⅳ. Special notes for reviews