Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to update asts RevisionHistoryLimit #864

Conversation

shiyan2016
Copy link
Member

Ⅰ. Describe what this PR does

allow to update asts RevisionHistoryLimit

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: shiyan2016 <shiyan20160606@gmail.com>
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Dec 24, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #864 (a4b1a71) into master (3ba6f4a) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
- Coverage   48.22%   48.13%   -0.09%     
==========================================
  Files         118      118              
  Lines       11042    11043       +1     
==========================================
- Hits         5325     5316       -9     
- Misses       4906     4922      +16     
+ Partials      811      805       -6     
Flag Coverage Δ
unittests 48.13% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...k/statefulset/validating/statefulset_validation.go 51.93% <0.00%> (-0.29%) ⬇️
pkg/controller/daemonset/update.go 24.24% <0.00%> (-2.53%) ⬇️
pkg/controller/daemonset/daemonset_util.go 63.75% <0.00%> (-2.02%) ⬇️
pkg/controller/daemonset/daemonset_controller.go 37.25% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba6f4a...a4b1a71. Read the comment docs.

@FillZpp
Copy link
Member

FillZpp commented Dec 24, 2021

It seems the built-in StatefulSet does not allow to modify the revisionHistoryLimit field. But I think it will not break anything if it is mutable?

@shiyan2016
Copy link
Member Author

It seems the built-in StatefulSet does not allow to modify the revisionHistoryLimit field. But I think it will not break anything if it is mutable?

yes, and I think it is reasonable for revisionHistoryLimit mutable.

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 28e7eb3 into openkruise:master Dec 27, 2021
FillZpp pushed a commit that referenced this pull request Jan 21, 2022
Signed-off-by: shiyan2016 <shiyan20160606@gmail.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants