-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to update asts RevisionHistoryLimit #864
allow to update asts RevisionHistoryLimit #864
Conversation
Signed-off-by: shiyan2016 <shiyan20160606@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #864 +/- ##
==========================================
- Coverage 48.22% 48.13% -0.09%
==========================================
Files 118 118
Lines 11042 11043 +1
==========================================
- Hits 5325 5316 -9
- Misses 4906 4922 +16
+ Partials 811 805 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
It seems the built-in StatefulSet does not allow to modify the |
yes, and I think it is reasonable for revisionHistoryLimit mutable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: shiyan2016 <shiyan20160606@gmail.com>
Ⅰ. Describe what this PR does
allow to update asts RevisionHistoryLimit
Ⅱ. Does this pull request fix one issue?
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews