Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing docs #870

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Dec 29, 2021

Signed-off-by: FillZpp FillZpp.pub@gmail.com

Ⅰ. Describe what this PR does

Update contributing docs

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Dec 29, 2021
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@FillZpp FillZpp force-pushed the update-contributing-docs branch from 2e27320 to c559fa5 Compare December 29, 2021 07:28
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #870 (c559fa5) into master (797935c) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
- Coverage   48.02%   47.84%   -0.19%     
==========================================
  Files         118      119       +1     
  Lines       11092    11235     +143     
==========================================
+ Hits         5327     5375      +48     
- Misses       4958     5042      +84     
- Partials      807      818      +11     
Flag Coverage Δ
unittests 47.84% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/inplaceupdate/inplace_update_defaults.go 40.31% <0.00%> (ø)
pkg/controller/cloneset/cloneset_status.go 83.78% <0.00%> (-5.41%) ⬇️
pkg/controller/cloneset/cloneset_controller.go 50.59% <0.00%> (-2.38%) ⬇️
pkg/control/sidecarcontrol/util.go 49.03% <0.00%> (-0.31%) ⬇️
pkg/controller/sidecarset/sidecarset_processor.go 70.00% <0.00%> (-0.12%) ⬇️
pkg/controller/sidecarset/sidecarset_controller.go 13.88% <0.00%> (ø)
pkg/control/sidecarcontrol/history_control.go 0.00% <0.00%> (ø)
pkg/controller/uniteddeployment/revision.go 67.69% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 797935c...c559fa5. Read the comment docs.

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@FillZpp
Copy link
Member Author

FillZpp commented Dec 29, 2021

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FillZpp FillZpp merged commit 586e2dc into openkruise:master Dec 29, 2021
FillZpp added a commit that referenced this pull request Jan 21, 2022
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants