Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make maxUnavailable also limited to pods in new revision #899

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Jan 24, 2022

Signed-off-by: FillZpp FillZpp.pub@gmail.com

Ⅰ. Describe what this PR does

Make maxUnavailable also limited to pods in new revision

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

fixes #898

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/M size/M: 30-99 label Jan 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2022

Codecov Report

Merging #899 (afce790) into master (af3e254) will increase coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   47.89%   47.94%   +0.04%     
==========================================
  Files         119      119              
  Lines       11239    11243       +4     
==========================================
+ Hits         5383     5390       +7     
+ Misses       5039     5029      -10     
- Partials      817      824       +7     
Flag Coverage Δ
unittests 47.94% <83.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/sync/cloneset_update.go 46.15% <83.33%> (+1.21%) ⬆️
pkg/controller/cloneset/cloneset_controller.go 50.59% <0.00%> (-2.38%) ⬇️
pkg/controller/daemonset/daemonset_controller.go 36.38% <0.00%> (-0.88%) ⬇️
pkg/controller/daemonset/daemonset_util.go 65.77% <0.00%> (+2.01%) ⬆️
pkg/controller/daemonset/update.go 26.76% <0.00%> (+2.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af3e254...afce790. Read the comment docs.

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@FillZpp FillZpp force-pushed the cloneset-unavailable-limits-for-new-revision branch from 74f861e to afce790 Compare January 25, 2022 08:03
@kruise-bot kruise-bot added size/L size/L: 100-499 and removed size/M size/M: 30-99 labels Jan 25, 2022
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@FillZpp
Copy link
Member Author

FillZpp commented Jan 26, 2022

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit a08636a into openkruise:master Jan 26, 2022
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] maxUnavailable not working when pods not ready
4 participants