-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make maxUnavailable also limited to pods in new revision #899
Make maxUnavailable also limited to pods in new revision #899
Conversation
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 47.89% 47.94% +0.04%
==========================================
Files 119 119
Lines 11239 11243 +4
==========================================
+ Hits 5383 5390 +7
+ Misses 5039 5029 -10
- Partials 817 824 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
74f861e
to
afce790
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: FillZpp FillZpp.pub@gmail.com
Ⅰ. Describe what this PR does
Make maxUnavailable also limited to pods in new revision
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
fixes #898
Ⅳ. Special notes for reviews