Optimize inplace update and support pod-template-hash label for cloneset #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
furykerry
reviewed
Mar 18, 2022
| @@ -198,6 +206,22 @@ func (c *realControl) refreshPodState(cs *appsv1alpha1.CloneSet, coreControl clo | |||
| return false, res.DelayDuration, nil | |||
| } | |||
|
|
|||
| func (c *realControl) fixPodTemplateHashLabel(cs *appsv1alpha1.CloneSet, pod *v1.Pod) (bool, error) { | |||
There was a problem hiding this comment.
please comment the history and reason of why we need "fix" template hash. It seems that previously we only has controllerrevisionhash in the pod
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
FillZpp
force-pushed
the
optimize-inplace-update-and-add-hash-label
branch
from
d72d698 to
20ba503
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: FillZpp FillZpp.pub@gmail.com
Ⅰ. Describe what this PR does
Optimize inplace update and support
pod-template-hashlabel for cloneset.Now there are two hash labels in pods that managed by cloneset:
controller-revision-hashis still the important one that indicates the pod version. It defaults to be"{CLONESET_NAME}-{HASH}", and it will be"{HASH}"if user enabled theCloneSetShortHashfeature-gate.pod-template-hashshould always be the short format"{HASH}". cloneset-controller will not rely on it, but some other controllers, such as kruise-rollout, may use it to be the service selector.