Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jobsidecarterminator yaml format #163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hantmac
Copy link
Member

@hantmac hantmac commented Feb 19, 2024

Now the yaml in this page is not correct:
image

Signed-off-by: hantmac <hantmac@outlook.com>
@ls-2018
Copy link
Member

ls-2018 commented Feb 28, 2024

/lgtm

@kruise-bot
Copy link

New changes are detected. LGTM label has been removed.

@hantmac
Copy link
Member Author

hantmac commented Mar 23, 2024

New changes are detected. LGTM label has been removed.

Thanks!

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ls-2018
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants