Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the SidecarTerminator feature gate name #177

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

ls-2018
Copy link
Member

@ls-2018 ls-2018 commented Apr 13, 2024

No description provided.

@ls-2018
Copy link
Member Author

ls-2018 commented Apr 13, 2024

/retest

Signed-off-by: acejilam <acejilam@gmail.com>
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit a8dac79 into openkruise:master Jun 20, 2024
6 checks passed
@ls-2018 ls-2018 deleted the jst branch June 20, 2024 07:43
furykerry pushed a commit to furykerry/openkruise.io that referenced this pull request Jul 3, 2024
Signed-off-by: acejilam <acejilam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants