fix log sidecar container docs #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furykerry
reviewed
Jun 20, 2024
| name: filebeat-config | ||
| - name: log | ||
| emptyDir: {} | ||
| name: config |
There was a problem hiding this comment.
still indentation problem here
| @@ -91,22 +91,19 @@ metadata: | |||
| name: filebeat-sidecarset | |||
| spec: | |||
| selector: | |||
| # Pod labels that need to be injected into the sidecar container | |||
There was a problem hiding this comment.
there is also indentation problem in L33, around the line
K8S Sidecar Model Disadvantage
in addition, please add the resource declaration in the code blocks(add apiserver, kind part)
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
furykerry
pushed a commit
to furykerry/openkruise.io
that referenced
this pull request
Jul 3, 2024
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.