Advanced deployment scale down old unhealthy pods firstly #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #150 +/- ##
==========================================
- Coverage 44.67% 43.44% -1.23%
==========================================
Files 48 50 +2
Lines 5077 5361 +284
==========================================
+ Hits 2268 2329 +61
- Misses 2432 2635 +203
- Partials 377 397 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
veophi
changed the title
veophi
force-pushed
the
Fix-deployment-scale
branch
from
72d2d83
to
74080d2
Compare
veophi
force-pushed
the
Fix-deployment-scale
branch
3 times, most recently
from
22653a4
to
825504f
Compare
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
veophi
force-pushed
the
Fix-deployment-scale
branch
from
825504f
to
a1fef3a
Compare
furykerry
reviewed
Jul 3, 2023
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
veophi
force-pushed
the
Fix-deployment-scale
branch
from
49a4d60
to
390aff5
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kuromesi
pushed a commit
to Kuromesi/rollouts
that referenced
this pull request
Jul 17, 2023
…#150) * advanced deployment scale down old unhealthy pods firstly Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> * add e2e for advanced deployment scale down old unhealthy pod first Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> --------- Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
zmberg
pushed a commit
that referenced
this pull request
Jul 18, 2023
* advanced deployment scale down old unhealthy pods firstly Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> * add e2e for advanced deployment scale down old unhealthy pod first Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> --------- Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
fixes #149
Ⅱ. Does this pull request fix one issue?
Ⅲ. Special notes for reviews