Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add handleDeployment warn log #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add handleDeployment warn log #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/webhook/workload/mutating/workload_update_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@
if newObj.Spec.Strategy.Type == apps.RecreateDeploymentStrategyType {
modified = true
newObj.Spec.Strategy = oldObj.Spec.Strategy
klog.Warningf("")
klog.Warningf("Cannot modify strategy for deployment %s/%s when deployment's strategy type is Recreate", newObj.Namespace, newObj.Name)

Check warning on line 293 in pkg/webhook/workload/mutating/workload_update_handler.go

View check run for this annotation

Codecov / codecov/patch

pkg/webhook/workload/mutating/workload_update_handler.go#L293 

Added line #L293 was not covered by tests
}
}
return modified, nil
Expand Down
Loading