Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't check for strategy when finalize #198

Conversation

phantomnat
Copy link
Contributor

Ⅰ. Describe what this PR does

hopefully, fix the #197

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

@kruise-bot
Copy link

Welcome @phantomnat! It looks like this is your first PR to openkruise/rollouts 🎉

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 43.42%. Comparing base (678d4d2) to head (367fe97).
Report is 2 commits behind head on master.

Files Patch % Lines
...lease/control/partitionstyle/deployment/control.go 50.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   43.41%   43.42%           
=======================================
  Files          52       52           
  Lines        5675     5679    +4     
=======================================
+ Hits         2464     2466    +2     
- Misses       2786     2787    +1     
- Partials      425      426    +1     
Flag Coverage Δ
unittests 43.42% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veophi
Copy link
Member

veophi commented Apr 2, 2024

/lgtm

@zmberg
Copy link
Member

zmberg commented Apr 2, 2024

/lgtm

@zmberg
Copy link
Member

zmberg commented Apr 2, 2024

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 07c1731 into openkruise:master Apr 2, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants