Remove oli externs #1021
Closed
Remove oli externs #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not remove this. More on that tomorrow. |
|
Thanks @elemoine. |
|
Please share your discussion on this if you can. I'm interested. |
|
#706 – custom controls. setMap must not be renamed within the lib for ol.Map#addControl to be able to call setMap on a (non-compiled) custom control. The same would apply to handleMapBrowserEvent if we supported custom interactions. |
afabiani
pushed a commit
to geosolutions-it/openlayers
that referenced
this pull request
Nov 7, 2017
Add parser for TMS Capabilities (r=@ahocevar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is left over from previous learning, maybe related to preventing renaming of
ol.control.setMap. I haven't properly tested it (except that Travis passes) but I think it's a dinosaur and we should make it extinct unless there's something I've missed.