Ensure a unique tile key for each tile coordinate #11646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
changed the title
tschaub
approved these changes
Oct 20, 2020
|
Thanks for the additional explanation (wasn’t obvious looking at the diff alone). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of providing a
getKey()method for each subclass ofol/Tile, we can use the one fromol/Tileif we set thekeyon the instance.In particular, this pull request fixes issues with custom
tileLoadFunctions in applications, in which case there is no need to configure the tile source with a uniqueurlfor each tile coordinate. Theol/TilegetKey()function ensures that the tile coordinate is part of the key, to make it unique. The unique key is needed for the tile queue.Fixes #11626