Allow any return type from listener functions #12509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12508.
With the current event listener types, something like this would not pass the type checks:
This is because the listener function is expected to return a boolean value or void.
In practice, we don't really care about the return value. Returning
false
from a listener function is equivalent to callingstopPropagation()
on the event, but any other return type works too.This pull request changes the expected return type to
any
, so the above snippet will now pass type checks.