Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle resolution and tile loadingstrategy with user projection #12731

Merged
merged 3 commits into from
Sep 10, 2021

Conversation

ahocevar
Copy link
Member

@ahocevar ahocevar commented Sep 9, 2021

This pull request fixes two problems with vector tile loaders:

  • Resolutions need to be adjusted when units of user and view projection are different. This also fixes one of the problems described in Issues with vector loaders when using useGeographic() #10881.
  • Assuming we always interact with tile grids in view projection, the tile grid passed to ol/loadingstrategy/tile needs to be in view projection.

The pull request adds a new example that shows how to use a tile loading strategy with useGeographic().

@mike-000
Copy link
Contributor

The example needs Geographic in the title and tags to distinguish it from the existing example

Copy link
Member

@tschaub tschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this, @ahocevar

@ahocevar ahocevar merged commit f0b3ce6 into openlayers:main Sep 10, 2021
@ahocevar ahocevar deleted the user-resolution branch September 10, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants