Do not render vector tiles unless they are being used #12778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
force-pushed
the
vectortile-remove-extra-work
branch
from
1cbba91 to
f544c80
Compare
ahocevar
force-pushed
the
vectortile-remove-extra-work
branch
from
f544c80 to
610fd69
Compare
tschaub
reviewed
Sep 18, 2021
| const hifi = !( | ||
| viewHints[ViewHint.ANIMATING] || viewHints[ViewHint.INTERACTING] | ||
| ); | ||
| if (hifi || !tile.wantedResolution) { | ||
| tile.wantedResolution = resolution; |
There was a problem hiding this comment.
Do we not need to know tile.wantedResolution any more?
There was a problem hiding this comment.
We do need to know it, and we still set it in getTile().
tschaub
approved these changes
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes code that causes quite a bit of overhead in the vector tile renderer: rendering a tile immediately after loading bypasses our logic that makes sure we only render tiles that are actually being used (
frameState.usedTiles). That code originally was meant for better making use of a render frame, but in practice, it causes more work because it renders tiles during/after zoom animations that are not needed for rendering the target resolution.This pull request is best reviewed without looking at whitespace changes.