Allow canvas reuse for WebGL layers #12965
Conversation
|
I'm reworking how we manage the map property on layers. Consider this back in draft status. |
tschaub
changed the title
|
I'm going to pull this apart into multiple pull requests to make review easier. |
| @@ -255,9 +255,6 @@ function parseStyle(style, bandCount) { | |||
| * property on the layer object; for example, setting `title: 'My Title'` in the | |||
| * options means that `title` is observable, and has get/set accessors. | |||
| * | |||
| * **Important**: after removing a `WebGLTile` layer from your map, call `layer.dispose()` | |||
| * to clean up underlying resources. | |||
There was a problem hiding this comment.
Cleanup of the canvas and associated resources happens when you remove a layer from the map now.
tschaub
changed the title
|
This is now ready for review. |
There was a problem hiding this comment.
Thanks for this great improvement! I could test it out on the layer swipe example, it works seamlessly. I also tried on the Heatmap example by switching the background to a webgl Tile layer and both layers also shared the same context.
I was worried that this would bring too much complexity to the renderer but, as it is now, I think that's not the case. Nothing to add on my side, great implementation, thanks again!
|
|
||
| varying vec2 v_texCoord; | ||
|
|
||
| void main() { | ||
| gl_FragColor = texture2D(u_image, v_texCoord); | ||
| gl_FragColor = texture2D(u_image, v_texCoord) * u_opacity; |
There was a problem hiding this comment.
Nice, this way opacity can be handled per layer without bailing on context sharing!
The goal of this branch is to make it possible to share canvas elements between WebGL layers.
As with Canvas layers, WebGL layers only share a canvas if they are adjacent in render order and share a class name.
To make for easier review, I'm splitting this work up into a few different pieces:
After the above changes are in, the remaining changes will be about adding a canvas cache key to helpers and sharing canvas elements when helpers are created with the same key. Layer renderers are responsible for generating the key based on whether or not a canvas element can be shared.
Fixes #12800.