-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing to pass additional options to the geotiff.js source #13290
Allowing to pass additional options to the geotiff.js source #13290
Conversation
geotiff.js source
📦 Preview the examples and docs from this branch here: https://deploy-preview-13290--ol-site.netlify.app/. |
geotiff.js sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two more suggestions. If you can address these, then this is good to go. Thanks!
Co-authored-by: Andreas Hocevar <andreas.hocevar@gmail.com>
Co-authored-by: Andreas Hocevar <andreas.hocevar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @constantinius
Would anybody object if we just added an This would mean you would have to repeat options share among multiple sources. But it would also mean you could have separate options for each of that were ever needed. I can prepare a pull request if it sounds ok. |
Fixes #13289