Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing to pass additional options to the geotiff.js source #13290

Merged
merged 4 commits into from
Jan 28, 2022

Conversation

constantinius
Copy link
Contributor

Fixes #13289

src/ol/source/GeoTIFF.js Outdated Show resolved Hide resolved
@github-actions
Copy link

📦 Preview the examples and docs from this branch here: https://deploy-preview-13290--ol-site.netlify.app/.

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two more suggestions. If you can address these, then this is good to go. Thanks!

src/ol/source/GeoTIFF.js Outdated Show resolved Hide resolved
src/ol/source/GeoTIFF.js Outdated Show resolved Hide resolved
constantinius and others added 2 commits January 27, 2022 14:44
Co-authored-by: Andreas Hocevar <andreas.hocevar@gmail.com>
Co-authored-by: Andreas Hocevar <andreas.hocevar@gmail.com>
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @constantinius

@ahocevar ahocevar merged commit 59600a0 into openlayers:main Jan 28, 2022
@constantinius constantinius deleted the geotiff-source-options branch January 28, 2022 09:35
@tschaub
Copy link
Member

tschaub commented Jan 28, 2022

Would anybody object if we just added an options property to the existing source info object (as a sibling of url and overviews)?

https://github.com/constantinius/openlayers/blob/441cce8dc702431a6958bc2a635c3c776cc53e52/src/ol/source/GeoTIFF.js#L25

This would mean you would have to repeat options share among multiple sources. But it would also mean you could have separate options for each of that were ever needed.

I can prepare a pull request if it sounds ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoTIFF source additional options
3 participants