Improve some nullable map types #13328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
requested changes
Feb 4, 2022
|
📦 Preview the examples and docs from this branch here: https://deploy-preview-13328--ol-site.netlify.app/. |
EvertEt
force-pushed
the
strictnullchecks-3
branch
from
43e3a5b
to
be6dac8
Compare
EvertEt
commented
Feb 4, 2022
EvertEt
commented
Feb 4, 2022
EvertEt
commented
Feb 4, 2022
| @@ -121,7 +121,7 @@ class Control extends BaseObject { | |||
| } | |||
| this.listenerKeys.length = 0; | |||
| this.map_ = map; | |||
| if (this.map_) { | |||
| if (map) { | |||
There was a problem hiding this comment.
Better TS type inference inside the if
EvertEt
force-pushed
the
strictnullchecks-3
branch
from
be6dac8
to
15de4bb
Compare
EvertEt
commented
Feb 5, 2022
EvertEt
force-pushed
the
strictnullchecks-3
branch
from
7f3dc0b
to
7b6afcd
Compare
ahocevar
approved these changes
Feb 7, 2022
| return /** @type {import("./PluggableMap.js").default|undefined} */ ( | ||
| this.get(Property.MAP) | ||
| return /** @type {import("./PluggableMap.js").default|null} */ ( | ||
| this.get(Property.MAP) || null |
There was a problem hiding this comment.
Although this looks like a breaking change, it actually only fixes the inconsistency that when previouslyMap#removeOverlay() was called, a subsequent call of Overlay#getMap() returned null, but when called after Overlay creation, it returned undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13326
I left out the interactions for now, they could probably also be improved.