Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backgrounds when function returns a different color #13550

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

ahocevar
Copy link
Member

@ahocevar ahocevar commented Apr 9, 2022

This pull request fixes a problem with background functions: when the map has only one layer and a background function returns different values on subsequent calls, the background of the container was not updated. This pull request fixes that.

The test case is a good explanation. Previously, the second assertion failed, because the background was still ''.

@ahocevar ahocevar changed the title Make sure backgrounds are updated when function returns a different c… Update backgrounds when function returns a different color Apr 9, 2022
@github-actions
Copy link

github-actions bot commented Apr 9, 2022

📦 Preview the examples and docs from this branch here: https://deploy-preview-13550--ol-site.netlify.app/.

@ahocevar ahocevar merged commit ae00bf6 into openlayers:main Apr 9, 2022
@ahocevar ahocevar deleted the background branch April 9, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants