Add null return type #13673
Add null return type #13673
Conversation
|
📦 Preview the examples and docs from this branch here: https://deploy-preview-13673--ol-site.netlify.app/. |
| @@ -287,7 +287,7 @@ class ExecutorGroup { | |||
|
|
|||
| /** | |||
| * @param {import("../../transform.js").Transform} transform Transform. | |||
| * @return {Array<number>} Clip coordinates. | |||
| * @return {Array<number>|null} Clip coordinates. | |||
There was a problem hiding this comment.
Would it be good to also add a guard in the ExecutorGroup.clip already?
There was a problem hiding this comment.
@EvertEt I did not do that, because it would be inefficient. The caller function already guards against the condition that would make getClipCoords() return null. So some refactoring would be in order there.
There was a problem hiding this comment.
I see, since we did check it, I would normally consider casting (with an optional comment) but I am not sure the syntax keeps it readable and since it's not always guaranteed I am doubtful. But we will stumble across again when we enable strictNullChecks
const flatClipCoords = /** @type {Array<number>} */ (
this.getClipCoords(transform)
);
Follow up on #13672: add
nullas return type forgetClipCoords(), in preparation for thestrictNullChecks: trueTypeScript configuration.