-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style updates for examples and API docs #13917
Conversation
📦 Preview the examples and docs from this branch here: https://deploy-preview-13917--ol-site.netlify.app/. |
@MoonE - Thanks for the feedback. I also thought that the links were not obvious enough and that the inline code style was too subtle. I've updated both (and included screenshots in the description). The links now use the brand color and are decorated with an underline on focus or hover. The inline code now has a background that contrasts with the default background. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the clean look. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered removing the background color from the big code boxes?
Either way it looks great, @tschaub
Hi |
@jipexu - The branch preview builds don’t include all the docs currently - just the examples and API docs. |
@tschaub ah ok thank for the light ! |
Following up on #13908, this updates styles for examples and API docs. Aside from code syntax highlighting, the one color is
#00AAFF
(the new brand color), and the rest is grayscale. The includedlogo-light.svg
andlogo-dark.svg
can be used over light and dark backgrounds.New style for API docs:
New style for examples:
(The cookie consent form has colors that stray from the theme, but that will be removed in #13916.)